mytang0 commented on code in PR #1037:
URL:
https://github.com/apache/incubator-eventmesh/pull/1037#discussion_r931828266
##########
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/tcp/client/group/ClientSessionGroupMapping.java:
##########
@@ -133,11 +133,11 @@ public void operationComplete(ChannelFuture future)
throws Exception {
return;
}
- closeSession(session);
-
//remove session from sessionTable
sessionTable.remove(addr);
+ closeSession(session);
+
Review Comment:
> Can you describe the specific problem, I don't understand what the
original way would cause.
When the client channel is inactive and the session is closed, the client
reconnects and the closed session is acquired and used. So first
sessionTable.remove, then closeSession.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
