HeZean commented on PR #1105: URL: https://github.com/apache/incubator-eventmesh/pull/1105#issuecomment-1207701037
Hi @qqeasonchen, I just remembered that most changes are related to `Constants.DEFAULT_CHARSET`, which was changed from string "UTF-8" to charset `StandardCharset.UTF_8`, splitting this PR may be not that feasible since it would break some code (e.g. some code was `Charset.forName(Constants.DEFAULT_CHARSET)` should be changed to `Constants.DEFAULT_CHARSET`) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
