pchengma opened a new pull request, #1342:
URL: https://github.com/apache/incubator-eventmesh/pull/1342
<!--
### Contribution Checklist
- Name the pull request in the form "[ISSUE #XXXX] Title of the pull
request",
where *XXXX* should be replaced by the actual issue number.
Skip *[ISSUE #XXXX]* if there is no associated github issue for this
pull request.
- Fill out the template below to describe the changes contributed by the
pull request.
That will give reviewers the context they need to do the review.
- Each pull request should address only one issue.
Please do not mix up code from multiple issues.
- Each commit in the pull request should have a meaningful commit message.
- Once all items of the checklist are addressed, remove the above text and
this checklist,
leaving only the filled out template below.
(The sections below can be removed for hotfixes of typos)
-->
<!--
(If this PR fixes a GitHub issue, please add `Fixes #<XXX>` or `Cloese
#<XXX>`.)
-->
Fixed #1307.
### Motivation
*Support cluster-mode and broadcast-mode listener in Knative-Connector.*
*This PR will be merged into knative-connector branch first.*
### Modifications
#### Logic
Listener (cluster or broadcast mode) calls ```consume``` method after
```subscribe``` according to action type (CommitMessage, ReconsumeLater, or
ManualACK).
#### Implementation
- Added broadcast-mode message listener
- Added ```consume``` statement calling in ```subscribe``` method
#### How to Test
Same as the integration test steps in demo (see
[document](https://github.com/apache/incubator-eventmesh/blob/master/docs/zh/connector-knative/01-eventmesh-connector-knative.md)
for details)
### Documentation
- Does this pull request introduce a new feature? Yes.
- If yes, how is the feature documented? Not documented.
- If a feature is not documented yet in this PR, please create a followup
issue for adding the documentation. The documentation issue will be created
along with another PR specifically for documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
