KxxxxxX opened a new pull request, #1847:
URL: https://github.com/apache/incubator-eventmesh/pull/1847

   Fixes #1845 .
   
   ### Motivation
   
   located at:
   
org/apache/eventmesh/connector/knative/cloudevent/impl/KnativeBinaryMessageReader.java
 line 34
   explanation:
   This line has the form String str = str.equals("someOtherString")
   If the string variable str is null, a NullPointerException may occur. if the 
code is adapted to String str = "someOtherString".equals(str)
   That is, if you call equals() on a string literal, passing the variable as 
an argument, then this exception will not occur because equals() will check for 
null.
   
   
   
   ### Modifications
   
   before 
   ```java
       @Override
       protected boolean isContentTypeHeader(String key) {
           return key.equals(KnativeHeaders.CONTENT_TYPE);
       }
   ```
   
   after
   ```java
      @Override
       protected boolean isContentTypeHeader(String key) {
           return KnativeHeaders.CONTENT_TYPE.equals(key);
       }
   ```
   
   
   
   ### Documentation
   
   - Does this pull request introduce a new feature?  no
   
   
   
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to