jonyangx commented on code in PR #2584:
URL:
https://github.com/apache/incubator-eventmesh/pull/2584#discussion_r1047996683
##########
eventmesh-common/src/main/java/org/apache/eventmesh/common/utils/IPUtils.java:
##########
@@ -104,12 +104,9 @@ public static String getLocalAddress() {
//If failed to find,fall back to localhost
final InetAddress localHost = InetAddress.getLocalHost();
return normalizeHostAddress(localHost);
- } catch (SocketException e) {
- LOG.error("socket exception", e);
- } catch (UnknownHostException e) {
- LOG.error("unknown host exception", e);
+ } catch (SocketException | UnknownHostException e) {
+ LOG.error(e.getMessage());
Review Comment:
suggest log error with exception object ,not message.
LOG.error(message,e);
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
