xwm1992 commented on code in PR #2588:
URL:
https://github.com/apache/incubator-eventmesh/pull/2588#discussion_r1048071790
##########
eventmesh-protocol-plugin/eventmesh-protocol-cloudevents/src/main/java/org/apache/eventmesh/protocol/cloudevents/resolver/grpc/GrpcMessageProtocolResolver.java:
##########
@@ -155,37 +148,37 @@ public static List<CloudEvent>
buildBatchEvents(BatchMessage batchMessage) {
String contentType =
item.getPropertiesOrDefault(ProtocolKey.CONTENT_TYPE,
Constants.CONTENT_TYPE_CLOUDEVENTS_JSON);
EventFormat eventFormat =
EventFormatProvider.getInstance().resolveFormat(contentType);
- CloudEvent event =
eventFormat.deserialize(cloudEventJson.getBytes(StandardCharsets.UTF_8));
+ CloudEvent event =
Objects.requireNonNull(eventFormat).deserialize(cloudEventJson.getBytes(StandardCharsets.UTF_8));
- String env = StringUtils.isEmpty(header.getEnv()) ?
event.getExtension(ProtocolKey.ENV).toString() : header.getEnv();
- String idc = StringUtils.isEmpty(header.getIdc()) ?
event.getExtension(ProtocolKey.IDC).toString() : header.getIdc();
- String ip = StringUtils.isEmpty(header.getIp()) ?
event.getExtension(ProtocolKey.IP).toString() : header.getIp();
- String pid = StringUtils.isEmpty(header.getPid()) ?
event.getExtension(ProtocolKey.PID).toString() : header.getPid();
- String sys = StringUtils.isEmpty(header.getSys()) ?
event.getExtension(ProtocolKey.SYS).toString() : header.getSys();
+ String env = StringUtils.isEmpty(header.getEnv()) ?
getEventExtension(event, ProtocolKey.ENV) : header.getEnv();
+ String idc = StringUtils.isEmpty(header.getIdc()) ?
getEventExtension(event, ProtocolKey.IDC) : header.getIdc();
+ String ip = StringUtils.isEmpty(header.getIp()) ?
getEventExtension(event, ProtocolKey.IP): header.getIp();
Review Comment:
here has a ci check error, need a white space after `(event, ProtocolKey.IP)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
