eight-nines commented on code in PR #2586:
URL:
https://github.com/apache/incubator-eventmesh/pull/2586#discussion_r1048602201
##########
eventmesh-common/src/main/java/org/apache/eventmesh/common/utils/Convert.java:
##########
@@ -362,26 +358,29 @@ public boolean isNotHandleNullValue() {
@Override
public List<Object> convert(ConvertInfo convertInfo) {
try {
- String key = convertInfo.getKey() + "[";
+ if (convertInfo.getValue() == null) {
+ return new ArrayList<>();
+ }
+ List<String> values = Splitter.on(",").omitEmptyStrings()
Review Comment:
em 配置文件里好像都是采用“,”分割列表，比如 “TCP,HTTP,GRPC” ；
列表长度个位数，性能上应该没问题；如果元素是对象，会按之前的逻辑，获取元素类型，然后解析每个元素，最后放到列表里返回，比如UT里的哪个 ip地址列表的解析
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
