jonyangx commented on code in PR #2688:
URL:
https://github.com/apache/incubator-eventmesh/pull/2688#discussion_r1057154439
##########
eventmesh-server-go/runtime/core/protocol/grpc/heartbeat/heartbeat_service.go:
##########
@@ -51,7 +52,7 @@ func (h *HeartbeatService) Heartbeat(ctx context.Context, hb
*pb.Heartbeat) (*pb
err error
)
h.pool.Submit(func() {
- resp, err = ProcessHeartbeat(h.gctx, hb)
+ resp, err = NewProcessor().Heartbeat(h.consumerMgr, hb)
Review Comment:
suggest use global variable , avoid new object action for each call Submit
method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
