Alonexc commented on issue #2702: URL: https://github.com/apache/incubator-eventmesh/issues/2702#issuecomment-1373198179
> Hi @xwm1992 @Alonexc , seems like this issue has already fixed and code has been updated. But I do have a suggestion on EventMeshRecommendImpl line 172 in recommendProxy() method, instead of looping through keys, retainAll method of Set after retrieving keySet() from Map, can be used to check if there exists a key in clientDistributionMap but not in eventMeshMap and vice versa if required insteading of looping through entire keySet. I can raise PR for the improvement I mentioned and we can close this issue once done. @mvadharia Ok, I see that it has been fixed and I will close the issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
