wqliang opened a new issue, #2852:
URL: https://github.com/apache/incubator-eventmesh/issues/2852

   ### Search before asking
   
   - [X] I had searched in the 
[issues](https://github.com/apache/eventmesh/issues?q=is%3Aissue) and found no 
similar issues.
   
   
   ### Enhancement Request
   
   There are almost same code for updating client infos and subscriptions in 
`org.apache.eventmesh.runtime.core.protocol.http.processor.LocalSubscribeEventProcessor`
 and 
`org.apache.eventmesh.runtime.core.protocol.http.processor.SubscribeProcessor`.
   
   In deatils, 
   - the local method `registerClient` in both Processor
   - the code in SubscribeProcessor(line192~263 and ) and 
LocalSubscribeEventProcessor(line176~247)
   
   It is better to manage the code to "update client info" and "update 
subscription info" in the same code block or a manager.
   
   ### Describe the solution you'd like
   
   Maybe we can:
   step1: add a manager to manage client info and subscription, for example 
`SubscriptionManager`;
   step2: consider wether we can combine `consumerManager` and 
`SubscriptionManager` together to manager all info in consumer side.
   
   ### Are you willing to submit PR?
   
   - [X] Yes I am willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to