eight-nines commented on code in PR #2917:
URL:
https://github.com/apache/incubator-eventmesh/pull/2917#discussion_r1069503082
##########
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/boot/EventMeshGrpcBootstrap.java:
##########
@@ -30,10 +30,12 @@ public class EventMeshGrpcBootstrap implements
EventMeshBootstrap {
private final Registry registry;
- public EventMeshGrpcBootstrap(ConfigurationWrapper configurationWrapper,
Registry registry) {
+ public EventMeshGrpcBootstrap(Registry registry) {
this.registry = registry;
- this.eventMeshGrpcConfiguration = new
EventMeshGrpcConfiguration(configurationWrapper);
- eventMeshGrpcConfiguration.init();
+
+ ConfigService configService = ConfigService.getInstance();
Review Comment:
In EventMeshStartup, we will set the path to the root configuration file and
eventually resolve to EventMeshTCPConfiguration, UT can refer to
EventMeshServerTest.
This design does not take into account the scenario of creating
EventMeshTCPConfiguration directly in the main process, but for use in UT you
can refer to EventMeshTCPConfigurationTest.
I will follow up with optimizations that have been documented.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
