Alonexc opened a new issue, #3082:
URL: https://github.com/apache/incubator-eventmesh/issues/3082

   ### Search before asking
   
   - [X] I had searched in the 
[issues](https://github.com/apache/eventmesh/issues?q=is%3Aissue) and found no 
similar issues.
   
   
   ### Enhancement Request
   
   
![image](https://user-images.githubusercontent.com/91315508/218018616-917d1022-dc2d-4b80-a5d2-b32503f3fe6a.png)
   located at:
   
eventmesh-common/src/main/java/org/apache/eventmesh/common/config/convert/ConvertValue.java
 line 61
   analysis and explanation:
   This method uses the Optional.orElse() method passing in some code that will 
execute immediately, whether or not the else case of the Optional is needed. 
This may cause incorrect side effects to happen, or at the minimum, code to 
execute for no reason.
   
   
   ### Describe the solution you'd like
   
   It would be better to use Optional.orElseGet().
   e.g.
   
![image](https://user-images.githubusercontent.com/91315508/218018657-6aed3063-976f-4e45-9502-56c22c209ee7.png)
   
   
   ### Are you willing to submit PR?
   
   - [ ] Yes I am willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to