jonyangx commented on code in PR #3119:
URL:
https://github.com/apache/incubator-eventmesh/pull/3119#discussion_r1103917760
##########
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/acl/Acl.java:
##########
@@ -26,14 +26,25 @@
import org.apache.commons.lang3.StringUtils;
import java.util.Properties;
-import java.util.ServiceLoader;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
public class Acl {
+
private static final Logger logger = LoggerFactory.getLogger(Acl.class);
- private static AclService aclService;
+
+ private static final Acl INSTANCE = new Acl();
+
+ private AclService aclService;
+
+ private Acl() {
+
+ }
+
+ public static Acl getInstance() {
Review Comment:
Suggest merge getInstance() and init() method.
eg. public static Acl getInstance(String aclPluginType) .
Add collection for Acl instannce and pluginType mapping.
@mxsm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
