jonyangx commented on code in PR #3133:
URL:
https://github.com/apache/incubator-eventmesh/pull/3133#discussion_r1105412491
##########
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/http/push/AsyncHTTPPushRequest.java:
##########
@@ -350,13 +349,7 @@ ClientRetCode processResponseContent(String content) {
handleMsgContext.getBizSeqNo(),
handleMsgContext.getUniqueId(), content);
}
return ClientRetCode.FAIL;
- } catch (JsonException e) {
- if (MESSAGE_LOGGER.isWarnEnabled()) {
- MESSAGE_LOGGER.warn("url:{}, bizSeqno:{}, uniqueId:{},
httpResponse:{}", currPushUrl,
- handleMsgContext.getBizSeqNo(),
handleMsgContext.getUniqueId(), content);
- }
- return ClientRetCode.FAIL;
- } catch (Throwable t) {
+ } catch (Throwable e) {
Review Comment:
Suggest catch Exception and not Throwable. @Bannirui
eg.
try {
......
} catch (JsonException e) {
} catch (Exception ex) {
}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
