mytang0 commented on code in PR #3111:
URL:
https://github.com/apache/incubator-eventmesh/pull/3111#discussion_r1108408373
##########
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/grpc/consumer/ConsumerManager.java:
##########
@@ -216,9 +216,7 @@ private void startClientCheck() {
}
final List<ConsumerGroupClient> clientList = new
LinkedList<>();
- clientTable.values().forEach(clients -> {
- clientList.addAll(clients);
- });
+ clientTable.values().forEach(clientList::addAll);
Review Comment:
This modification seems to have nothing to do with the pr title, it would be
better to commit separately next time
##########
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/http/retry/RetryContext.java:
##########
@@ -34,13 +34,7 @@ public RetryContext delay(long delay) {
@Override
public int compareTo(Delayed delayed) {
RetryContext obj = (RetryContext) delayed;
- if (this.executeTime > obj.executeTime) {
- return 1;
- } else if (this.executeTime == obj.executeTime) {
- return 0;
- } else {
- return -1;
- }
+ return Long.compare(this.executeTime, obj.executeTime);
Review Comment:
Hi, please add handling of "delay=null"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
