mxsm commented on code in PR #3194:
URL:
https://github.com/apache/incubator-eventmesh/pull/3194#discussion_r1110833510
##########
eventmesh-runtime/src/test/java/org/apache/eventmesh/runtime/client/impl/PubClientImpl.java:
##########
@@ -207,23 +208,19 @@ protected void channelRead0(ChannelHandlerContext ctx,
Package msg) throws Excep
if (context != null) {
contexts.remove(context.getKey());
context.finish(msg);
- return;
} else {
log.error("msg ignored,context not found .|{}|{}", cmd,
msg);
- return;
}
} else if (cmd == Command.SERVER_GOODBYE_REQUEST) {
- log.error("server goodby request: ---------------------------"
+ msg);
+ log.error("server goodbye request:
---------------------------" + msg);
Review Comment:
how about use log placeholder like this
```
log.error("server goodbye request: ---------------------------{}",msg)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
