mytang0 commented on code in PR #3324:
URL:
https://github.com/apache/incubator-eventmesh/pull/3324#discussion_r1123179432
##########
eventmesh-runtime/conf/eventmesh.properties:
##########
@@ -17,15 +17,15 @@
###############################EVNETMESH-runtime
ENV#################################
eventMesh.server.idc=DEFAULT
eventMesh.server.env=PRD
-eventMesh.server.provide.protocols=HTTP,TCP,GRPC
+eventMesh.server.provide.protocols=HTTP,TCP
eventMesh.server.cluster=COMMON
eventMesh.server.name=EVENTMESH-runtime
eventMesh.sysid=0000
eventMesh.server.http.port=10105
eventMesh.server.grpc.port=10205
########################## eventMesh tcp configuration
############################
eventMesh.server.tcp.enabled=true
-eventMesh.server.tcp.port=10002
+eventMesh.server.tcp.port=10102
eventMesh.server.tcp.readerIdleSeconds=120
Review Comment:
As above.
##########
eventmesh-runtime/conf/eventmesh.properties:
##########
@@ -17,15 +17,15 @@
###############################EVNETMESH-runtime
ENV#################################
eventMesh.server.idc=DEFAULT
eventMesh.server.env=PRD
-eventMesh.server.provide.protocols=HTTP,TCP,GRPC
+eventMesh.server.provide.protocols=HTTP,TCP
Review Comment:
Why modify it.
##########
eventmesh-connector-plugin/eventmesh-connector-pulsar/src/test/java/org/apache/eventmesh/connector/pulsar/config/ClientConfigurationTest.java:
##########
@@ -43,8 +43,8 @@ public void getConfigWhenPulsarProducerInit() {
}
private void assertConfig(ClientConfiguration config) {
- Assert.assertEquals(config.getServiceAddr(), "127.0.0.1:6650");
- Assert.assertEquals(config.getAuthPlugin(), "authPlugin-success!!!");
- Assert.assertEquals(config.getAuthParams(), "authParams-success!!!");
+ Assert.assertEquals(config.getServiceAddr(), null);
+ Assert.assertEquals(config.getAuthPlugin(), null);
+ Assert.assertEquals(config.getAuthParams(), null);
}
Review Comment:
This modification makes the testcase meaningless. You can try to locate the
root cause and then fix.
<img width="885" alt="image"
src="https://user-images.githubusercontent.com/29346818/222457873-55beb0fd-9e1f-4921-aa7c-ae8da7d9d5ed.png";>
Alternatively, you can refactor the relevant test cases.
##########
eventmesh-connector-plugin/eventmesh-connector-pulsar/src/main/java/org/apache/eventmesh/connector/pulsar/config/ClientConfiguration.java:
##########
@@ -36,4 +36,7 @@ public class ClientConfiguration {
@ConfigFiled(field = "authParams")
private String authParams;
+
+ @ConfigFiled(field = "topicPrefix")
+ private String topicPrefix;
}
Review Comment:
It may be better to add some descriptive information, such as application
scenarios.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
![https://user-images.githubusercontent.com/29346818/222457873-55beb0fd-9e1f-4921-aa7c-ae8da7d9d5ed.png"](https://user-images.githubusercontent.com/29346818/222457873-55beb0fd-9e1f-4921-aa7c-ae8da7d9d5ed.png"){kind=link}