dipankr opened a new pull request, #3698:
URL: https://github.com/apache/eventmesh/pull/3698
Modified two constants in MonitorMetricConstants
(EVENTMESH_MONITOR_FORMAT_COMMON, EVENTMESH_TCP_MONITOR_FORMAT_THREADPOOL) to
work without using String.format()
<!--
### Contribution Checklist
- Name the pull request in the form "[ISSUE #XXXX] Title of the pull
request",
where *XXXX* should be replaced by the actual issue number.
Skip *[ISSUE #XXXX]* if there is no associated github issue for this
pull request.
- Fill out the template below to describe the changes contributed by the
pull request.
That will give reviewers the context they need to do the review.
- Each pull request should address only one issue.
Please do not mix up code from multiple issues.
- Each commit in the pull request should have a meaningful commit message.
- Once all items of the checklist are addressed, remove the above text and
this checklist,
leaving only the filled out template below.
(The sections below can be removed for hotfixes of typos)
-->
<!--
(If this PR fixes a GitHub issue, please add `Fixes #<XXX>` or `Closes
#<XXX>`.)
-->
Fixes #2975
### Motivation
*Explain the content here.*
*Explain why you want to make the changes and what problem you're trying to
solve.*
removed String.format() and modified the format constants to use {} instead
of %s.
using {} doesn't require us to use String.format().
### Modifications
removed use of String.format()
modified format constants EVENTMESH_TCP_MONITOR_FORMAT_THREADPOOL,
EVENTMESH_MONITOR_FORMAT_COMMON
### Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
- If a feature is not applicable for documentation, explain why? (it is a
simple fix for an issue where we wanted to get rid of using String.format() as
it is not required by logger)
- If a feature is not documented yet in this PR, please create a followup
issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@eventmesh.apache.org
For additional commands, e-mail: dev-h...@eventmesh.apache.org
