pandaapo opened a new pull request, #4145: URL: https://github.com/apache/eventmesh/pull/4145
Fixes #4144. ### Motivation Subscription is almost impossible to be cancelled when the TCP sub client is closed. ### Modifications Because the subscription session can't be removed from `ClientGroupWrapper.topic2sessionInGroupMapping` correctly. When `Session` is added to the `topic2sessionInGroupMapping`, a `java.util.Set`, `Session.sessionState` is `CREATED`. But session is almost impossible to keep this state. It will be `RUNNING` or `CLOSED`. So the hash of `Session` is changed. `Map`(the base of `Set`) will be unable to find the bucket using the new hash, which is different from origin hash used when initially putting into `Map`. ### Documentation - Does this pull request introduce a new feature? (yes / no) - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented) - If a feature is not applicable for documentation, explain why? - If a feature is not documented yet in this PR, please create a followup issue for adding the documentation -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@eventmesh.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@eventmesh.apache.org For additional commands, e-mail: dev-h...@eventmesh.apache.org
