Pil0tXia opened a new pull request, #110:
URL: https://github.com/apache/eventmesh-site/pull/110

   Fixes #109.
   
   
![55b07433e099064891d9a7a68d9e48d](https://github.com/apache/eventmesh-site/assets/41445332/5c9ad421-bb06-4496-a604-82052c90ecb5)
   
   When inserting the config, the path contains `manufacturerName`, and the 
same logic applies when querying. Therefore, if we follow the request example 
in the documentation, it will result in an NPE (NullPointerException).
   
   
![de668469ccf5d20f22302fc5e2c1863](https://github.com/apache/eventmesh-site/assets/41445332/11bb064e-7cbf-4756-8937-8d242110cbc3)
   
   There are two possible solutions, with no impact on users. One way is to 
retrieve `manufacturerName` from `callbackPath` when making a query on our end. 
However, this would require specifying in the documentation that 
`manufacturerName` must be included in users' `callbackPath`, which doesn't 
seem like a common practice.
   
   A simpler solution is to include `manufacturerName` in the request. Since 
there are likely no users for our webhook at the moment, I will go with the 
latter option.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to