Pil0tXia opened a new pull request, #4835:
URL: https://github.com/apache/eventmesh/pull/4835

   <!--
   ### Contribution Checklist
   
     - Name the pull request in the form "[ISSUE #XXXX] Title of the pull 
request", 
       where *XXXX* should be replaced by the actual issue number.
       Skip *[ISSUE #XXXX]* if there is no associated github issue for this 
pull request.
   
     - Fill out the template below to describe the changes contributed by the 
pull request. 
       That will give reviewers the context they need to do the review.
     
     - Each pull request should address only one issue. 
       Please do not mix up code from multiple issues.
     
     - Each commit in the pull request should have a meaningful commit message.
   
     - Once all items of the checklist are addressed, remove the above text and 
this checklist, 
       leaving only the filled out template below.
   
   (The sections below can be removed for hotfixes of typos)
   -->
   
   <!--
   (If this PR fixes a GitHub issue, please add `Fixes #<XXX>` or `Closes 
#<XXX>`.)
   -->
   
   Fixes #4834
   
   ### Motivation
   
   Since `EventMeshTCPConfiguration`, `EventMeshHTTPConfiguration` and 
`EventMeshGrpcConfiguration` are subclasses of `CommonConfiguration`, their 
serialized JsonString would contain superclass fields, which enlarges the 
response body and brings in difficulty in getting `CommonConfiguration` fields.
   
   ### Modifications
   
   - Add a PropertyFilter to remove superclass fields from the JsonString of 
`EventMeshTCPConfiguration`, `EventMeshHTTPConfiguration` and 
`EventMeshGrpcConfiguration`, then add `CommonConfiguration` into the response 
body.
   - Add `configs` param which accepts two values, `exclusive` and `all`.
   - Add unified exception handling
   - The actual version number will be returned after merging 
https://github.com/apache/eventmesh/pull/4055.
   
   ### Documentation
   
   - Does this pull request introduce a new feature? (yes)
   - If yes, how is the feature documented? (JavaDocs)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@eventmesh.apache.org
For additional commands, e-mail: dev-h...@eventmesh.apache.org

Reply via email to