Pil0tXia opened a new pull request, #4839:
URL: https://github.com/apache/eventmesh/pull/4839
<!--
### Contribution Checklist
- Name the pull request in the form "[ISSUE #XXXX] Title of the pull
request",
where *XXXX* should be replaced by the actual issue number.
Skip *[ISSUE #XXXX]* if there is no associated github issue for this
pull request.
- Fill out the template below to describe the changes contributed by the
pull request.
That will give reviewers the context they need to do the review.
- Each pull request should address only one issue.
Please do not mix up code from multiple issues.
- Each commit in the pull request should have a meaningful commit message.
- Once all items of the checklist are addressed, remove the above text and
this checklist,
leaving only the filled out template below.
(The sections below can be removed for hotfixes of typos)
-->
<!--
(If this PR fixes a GitHub issue, please add `Fixes #<XXX>` or `Closes
#<XXX>`.)
-->
Fixes #4838
### Modifications
- Deprecate `eventMesh.connector.plugin.type`: EventMesh does not use this
config to determine which connector to use. This config can easily confuse
users. It is not referenced in implementation code either.
- Deprecate `registerIntervalInMills`, `fetchRegistryAddrIntervalInMills`:
These two configs were placed seperatly from metaStorage plugins, however they
are always (in Git history) misconfigured (missing `plugin` level) & not used
since EventMesh initated.
https://github.com/apache/eventmesh/blob/fe2bd7c840c9900ad7143099d89a1cc1905a9a09/eventmesh-runtime/conf/eventmesh.properties#L63-L64
https://github.com/apache/eventmesh/blob/fe2bd7c840c9900ad7143099d89a1cc1905a9a09/eventmesh-common/src/main/java/org/apache/eventmesh/common/config/CommonConfiguration.java#L70-L74
- Deprecate `eventMesh.server.defibus.client.comsumeTimeoutInMin` and
'defibus' related usages: These usages are commented and not used since
EventMesh initated, and may output one line of null log.
- Place similar properties together and add a seperator.
- I found out that I forgot to unify `null != object` in
https://github.com/apache/eventmesh/pull/4809 when writting this PR (only `null
== object` usages unified), so this PR contains supplements of the previous one.
### Documentation
- Does this pull request introduce a new feature? (no)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@eventmesh.apache.org
For additional commands, e-mail: dev-h...@eventmesh.apache.org
