qqeasonchen opened a new pull request, #5333: URL: https://github.com/apache/eventmesh/pull/5333
Adds a one-line attribution Javadoc in front of the RocketMQ 5 POP broker-ACK barrier block in `UniIngressService.deliver`, expanding the single-line `// P2 fix:` comment (preserved from the #5330 merge of PR #5316) into a 3-line block that references the originating PR (#5316) and the issue it fixes (#5295). The author is recorded as zhang-arvin (`[email protected]`) and the commit message carries the matching `Co-authored-by` trailer so the next reader can trace the broker-ACK semantics back to the original contribution. **No behavior change.** The barrier logic (AtomicInteger + per-delivery decrement + late broker ack) is byte-identical to the #5330 merge of #5316; this PR only extends the immediately-preceding comment. **Why a separate PR for a comment-only change?** The author/co-authored-by trailer on the squash-merged #5330 commit (`c7de75b`) does not include zhang-arvin — the squash merger (`Eason Chen <[email protected]>`) replaced the original author in the squash. The companion fix for #5325 (PR #5331) used this same pattern (a 0-diff PR with a `Co-authored-by: wangyusheng1985` trailer) to record that contributor's credit; this PR mirrors that approach for #5316. **Author attribution** (commit metadata, not the GH UI): - author: `zhang-arvin <[email protected]>` - author date: 2026-08-30T15:24:59+08:00 (matches zhang-arvin's original #5316 commit) - committer: `qqeasonchen <[email protected]>` - committer date: now **Files changed**: 1 file, +3 / -1 (comment block only) - `eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/ingress/UniIngressService.java` **References**: - Original PR: https://github.com/apache/eventmesh/pull/5316 - zhang-arvin's original commit: `1cdca51f` (`fix/5295-pop-broker-ack-barrier`) - Issue: #5295 - Code landed in #5330 (squash-merged as `c7de75b`) - Companion attribution PR for #5325: #5331 cc @zhang-arvin — please let me know if you'd prefer a different attribution form (e.g. moving the comment to the class-level Javadoc) and I'll adjust. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
