Lyin-OTTF opened a new pull request, #5434:
URL: https://github.com/apache/eventmesh/pull/5434
## What is the bug
`ReliableDispatcher#ackDelivery` runs the partition ownership guard for
every delivery:
```java
if (guard != null && !guard.test(d.getTopic(), d.getPartition())) { ...
StaleOwnerException ... }
```
`UniIngressService#deliverLocal` routes a locally delivered event with
`partition = -1` — the "no partition scope" marker. The ownership view only
ever holds real partition indexes, so `owned.contains(-1)` is always `false`
and **every ACK of such a delivery was rejected**. Fencing is a per-partition
concept; it does not apply to a delivery that has no partition.
The consequence chain:
1. `StaleOwnerException` escaped the HTTP handler, so the connection was
closed **without any response**.
2. `PushService#ack` removed the callback **before** invoking it, so the
client's retry was answered with `404 unknown deliveryId`.
3. The subscriber could neither acknowledge the event nor learn what
happened, and its offset never advanced.
## What the fix does
- **`ReliableDispatcher`** — run the ownership guard only for a delivery
that is bound to a partition (`partition >= 0`). Partition-less deliveries are
not fenced.
- **`PushService#ack`** — keep the ACK callback registered unless the ACK
actually succeeds, so a failed ACK stays ackable instead of turning into a 404.
- **`UniHttpServer`** — answer a fenced ACK with `409` including the
topic/partition, instead of letting the exception escape the handler. The
delivery is dropped on the fenced instance and the broker redelivers it to the
new owner (POP `invisibleTime`), so the client sees a real answer and a retry
is safe.
## Tests
- `StaleOwnerFencingTest` — new case: a delivery without partition scope is
not fenced; the existing partition-scoped fencing cases still pass.
- `PushServiceTest#failedAckKeepsTheDeliveryAckable` — a throwing ACK leaves
the delivery resolvable.
- `UniHttpServerAckErrorTest` (new) — ACK returns `409` for a fenced
delivery, `404` for an unknown one, `200` on success.
`./gradlew :eventmesh-runtime:test` — 12 tests in the three classes, 0
failures; full `:eventmesh-runtime:test` green.
Fixes #5432
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
