Hi Leif, Leif Mortenson wrote: > > I was doing to start digging in and working on the Instrument packages. > But it looks like the Instrument Manager directory has been reworked. > This was done in the Avalon repository but I was wondering what the > thinking here is. Currently the maven build does not work as it appears > to still expect the source files to all be in the same directory. I can > fix it > but I want to make sure I am on the same page.
why do you say the maven build does not work? in the latest svn repo, the following works fine for me: cd excalibur/instrument-manager maven multiproject:install > Also it looks like the pool and thread packages have been broken up into > instrumented and uninstrumented copies of the components. Is this really > necessary? I fear that the two will quickly diverge and become a > maintenance nightmare. If a user does not wish to use instrumentation > then all they need to do is include the instrument jar, which is extremely > small. I think it would be wise to get rid of the uninstrumented versions > and go back to only having one copy of the source. This is akin to creating > a version of the classes which do not do logging... Thoughts? I agree on the need to not make the implementations diverge. alternatively to having to include the instrument jar when one does require instrumentation, one could have the instrumentable components be made to reuse the non-instrumentable ones in some way (eg extending) and add the instrument specific functionality. in this way the component functionality will be in one place only. Cheers --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] Apache Excalibur Project -- URL: http://excalibur.apache.org/
