> On Jan. 11, 2015, 1:09 a.m., Srikanth Sundarrajan wrote: > > client/src/main/java/org/apache/falcon/cli/FalconCLI.java, line 87 > > <https://reviews.apache.org/r/19094/diff/2/?file=807650#file807650line87> > > > > Perhaps we can add an optional switch -force valid only on entity > > -update command instead of adding a new one. > > Ajay Yadava wrote: > Update command today needs a file to be submitted, if someone just wants > the side effects than I feel touch is a more convenient option. Also, usually > the force semantics are to allow changes which we want the users to warn > about and want to avoid being done accidentally, touch is more semantically > correct if we just want the side effects.
If we are to issue the update with the entity xml -update -force seems the right way to go about it. If we have no content to update with, (i.e) just update the oozie coords underneath with no change to entity,then -touch seems right. - Srikanth ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19094/#review67594 ----------------------------------------------------------- On Jan. 6, 2015, 8:41 a.m., pavan kumar kolamuri wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19094/ > ----------------------------------------------------------- > > (Updated Jan. 6, 2015, 8:41 a.m.) > > > Review request for Falcon and shwethags. > > > Repository: falcon-git > > > Description > ------- > > Add touch option to force update an entity in workflow engine(even without > any changes to entity) > > > Diffs > ----- > > client/src/main/java/org/apache/falcon/cli/FalconCLI.java ca514c1 > client/src/main/java/org/apache/falcon/client/FalconClient.java 7f1bc27 > > common/src/main/java/org/apache/falcon/workflow/engine/AbstractWorkflowEngine.java > f5b142b > docs/src/site/twiki/FalconCLI.twiki d37cf8c > docs/src/site/twiki/restapi/EntityTouch.twiki PRE-CREATION > > oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java > f1f96b1 > prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java > 4a686e7 > > prism/src/main/java/org/apache/falcon/resource/AbstractSchedulableEntityManager.java > a4d1f8b > > prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java > cfa70a0 > > webapp/src/main/java/org/apache/falcon/resource/SchedulableEntityManager.java > 2ec7f66 > webapp/src/test/java/org/apache/falcon/cli/FalconCLIIT.java 118003f > webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java > 40f8e04 > > Diff: https://reviews.apache.org/r/19094/diff/ > > > Testing > ------- > > Unit testing and end to end testing done > > > Thanks, > > pavan kumar kolamuri > >
