[
https://issues.apache.org/jira/browse/FALCON-822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14296280#comment-14296280
]
Srikanth Sundarrajan commented on FALCON-822:
---------------------------------------------
Does it make sense to move this to FeedLookupResult::toString()
{code}
+ public static String getString(FeedLookupResult feedLookupResult) {
{code}
It might improve readability if client.reverseLookup was in an independent
statement of its own.
{code}
+ result = ResponseHelper.getString(client.reverseLookUp(entityType,
feedInstancePath));
{code}
Where is this null? For Catalog based feed ?
{code}
FeedLocationStore::
+ if (clusterSpecificLocations != null) {
{code}
If reverseLookup() returns null, then NPE may result, It looks like
RadixTree::find() can return null.
{code}
+ Collection<FeedLookupResult.FeedProperties> feeds =
FeedLocationStore.get().reverseLookup(instancePath);
+ FeedLookupResult result = new
FeedLookupResult(APIResult.Status.SUCCEEDED, "SUCCESS");
+ FeedLookupResult.FeedProperties[] props = feeds.toArray(new
FeedLookupResult.FeedProperties[0]);
{code}
> Add reverse look up API
> -----------------------
>
> Key: FALCON-822
> URL: https://issues.apache.org/jira/browse/FALCON-822
> Project: Falcon
> Issue Type: Sub-task
> Components: general
> Reporter: Ajay Yadava
> Assignee: Ajay Yadava
> Attachments: FALCON-822.patch
>
>
> Expose reverse look up using Command Line interface and REST
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
