> On Jan. 22, 2015, 8:46 a.m., Pallavi Rao wrote: > > webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java, > > line 788 > > <https://reviews.apache.org/r/30116/diff/1/?file=828274#file828274line788> > > > > Since the update method is a synchronous call, don't think the test is > > simulating parallel update requests. The second update is called after the > > first one. > > > > Also, the second request should have really failed if the first one was > > still in progress, as an exception would be thrown. > > context.assertFailed(duplicateUpdateCommandResponse).
Agrred. Will open a ticket to add sufficient test in regression > On Jan. 22, 2015, 8:46 a.m., Pallavi Rao wrote: > > common/src/main/java/org/apache/falcon/entity/store/ConfigurationStore.java, > > line 73 > > <https://reviews.apache.org/r/30116/diff/1/?file=828272#file828272line73> > > > > MemoryLocks doesn't really belong here as it not stored in the config > > store. > > > > But, I understand you'll want a single instance of MemoryLocks. So, may > > be have a helper class for that. Or, make MemoryLocs a singleton and have > > it issue a "named set of locks" Have rebased the code > On Jan. 22, 2015, 8:46 a.m., Pallavi Rao wrote: > > common/src/main/java/org/apache/falcon/entity/store/ConfigurationStore.java, > > line 378 > > <https://reviews.apache.org/r/30116/diff/1/?file=828272#file828272line378> > > > > Seems like the getUpdateLock and releaseUpdateLock are not really > > adding much value here. May be they can be part of the MemoryLocks itself? Have rebased the code - Suhas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30116/#review69139 ----------------------------------------------------------- On Feb. 2, 2015, 12:51 p.m., Suhas Vasu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30116/ > ----------------------------------------------------------- > > (Updated Feb. 2, 2015, 12:51 p.m.) > > > Review request for Falcon. > > > Repository: falcon-git > > > Description > ------- > > In distributed mode, when parallel update command are issued for same entity, > they are not syncronized. > This leads to multiple coordinators being spawned in Oozie. > > We need to ensure that the update method is syncronized. > > > Diffs > ----- > > common/src/main/java/org/apache/falcon/entity/lock/MemoryLocks.java > PRE-CREATION > prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java > 0d34ef3 > > Diff: https://reviews.apache.org/r/30116/diff/ > > > Testing > ------- > > UT's were added and were successful > > > Thanks, > > Suhas Vasu > >
