> On Jan. 30, 2015, 2:17 a.m., Raghav Gautam wrote:
> > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/EntitySummaryTest.java,
> > line 292
> > <https://reviews.apache.org/r/30322/diff/1-3/?file=836390#file836390line292>
> >
> > If equality fails can we print a log message describing the same ?
>
> Ruslan Ostafiychuk wrote:
> If it fails for all instances in list we execute this line:
>
> >LOGGER.info("Instance " + instanceFromSummary.getInstance() + " not
> found in list.");
Also we already have a place where searched instance is logged along with a
whole list:
line 298: String.format("Instance {%s;%s;%s} is absent in list (or differs by
its properties)\n%s"
To me requested change seems redundant.
- Paul
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30322/#review70307
-----------------------------------------------------------
On Jan. 28, 2015, 2:57 p.m., Paul Isaychuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30322/
> -----------------------------------------------------------
>
> (Updated Jan. 28, 2015, 2:57 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: Falcon-1007
> https://issues.apache.org/jira/browse/Falcon-1007
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Modify test logging messages to make debugging easier, change variable names
> for better readability of code.
>
>
> Diffs
> -----
>
>
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/EntitySummaryTest.java
> 591810d
>
> Diff: https://reviews.apache.org/r/30322/diff/
>
>
> Testing
> -------
>
> Tested
>
>
> Thanks,
>
> Paul Isaychuk
>
>
