> On Jan. 30, 2015, 7:18 p.m., Raghav Gautam wrote: > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/CombinedActionsTest.java, > > line 213 > > <https://reviews.apache.org/r/25336/diff/8/?file=807724#file807724line213> > > > > This will not work on Windows and also, the test to be launched from > > the first cluster. From what I see in the test, ssh action is not testing > > any falcon feature. Other action check if all the parameters are passed to > > the workflow. > > > > In general, it is better to stay away from ssh - unless absolutely > > necessary.
Alright, will remove ssh action from the test for now. Will add a more meaningful test for ssh later in case such a need arises. Thanks. - Karishma ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25336/#review70402 ----------------------------------------------------------- On Jan. 6, 2015, 11:49 a.m., Karishma Gulati wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25336/ > ----------------------------------------------------------- > > (Updated Jan. 6, 2015, 11:49 a.m.) > > > Review request for Falcon. > > > Repository: falcon-git > > > Description > ------- > > A test needs to be added where one worflow has various possible actions like > mr, hive, pig. So far, we just specify the engine type as hive or pig for > such specific tests. > > > Diffs > ----- > > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/BundleUtil.java > 6e25a60 > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/ExecUtil.java > 82c8919 > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/HCatUtil.java > d878ecb > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/OSUtil.java > ed29d07 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/CombinedActionsTest.java > PRE-CREATION > falcon-regression/merlin/src/test/resources/combinedActions/cluster-0.1.xml > PRE-CREATION > > falcon-regression/merlin/src/test/resources/combinedActions/feed-template1.xml > PRE-CREATION > > falcon-regression/merlin/src/test/resources/combinedActions/feed-template1_hcat.xml > PRE-CREATION > > falcon-regression/merlin/src/test/resources/combinedActions/feed-template2.xml > PRE-CREATION > > falcon-regression/merlin/src/test/resources/combinedActions/feed-template2_hcat.xml > PRE-CREATION > > falcon-regression/merlin/src/test/resources/combinedActions/feed-template3.xml > PRE-CREATION > falcon-regression/merlin/src/test/resources/combinedActions/process-agg.xml > PRE-CREATION > falcon-regression/merlin/src/test/resources/combinedWorkflow/id.pig > PRE-CREATION > falcon-regression/merlin/src/test/resources/combinedWorkflow/script.hql > PRE-CREATION > falcon-regression/merlin/src/test/resources/combinedWorkflow/workflow.xml > PRE-CREATION > > Diff: https://reviews.apache.org/r/25336/diff/ > > > Testing > ------- > > > Thanks, > > Karishma Gulati > >
