> On Feb. 3, 2015, 9:09 p.m., Raghav Gautam wrote:
> > falcon-regression/merlin/src/main/java/org/apache/falcon/regression/testHelper/BaseTestClass.java,
> >  line 123
> > <https://reviews.apache.org/r/30450/diff/1/?file=841586#file841586line123>
> >
> >     We have introduced a new convention - that all the entities will start 
> > with the testname. Please update this info in the readme & send out and 
> > email to active merlin developers to get their feedback.

There is no similiar info in readme. generateRequiredBundle() can't be called 
without prefix after this patch.
New topic was created in Google group "Merlin-FalconQA"


- Ruslan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30450/#review70825
-----------------------------------------------------------


On Feb. 4, 2015, 2:29 p.m., Ruslan Ostafiychuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30450/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2015, 2:29 p.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-968
>     https://issues.apache.org/jira/browse/FALCON-968
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> all submitted entities should has test class name as prefix
> we can delete only entity which name starts with test class name
> all data should be uploaded/replicated to baseHDFSDir/TestName/..
> 
> 
> Diffs
> -----
> 
>   
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/Entities/ClusterMerlin.java
>  b1a94be 
>   
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/Entities/FeedMerlin.java
>  cec7684 
>   
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/Entities/ProcessMerlin.java
>  9ffc15d 
>   
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/Entities/TestEntityUtil.java
>  0d3e0ae 
>   
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/bundle/Bundle.java
>  91abe89 
>   
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/CleanupUtil.java
>  e997fc8 
>   
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/Util.java
>  58e3691 
>   
> falcon-regression/merlin/src/main/java/org/apache/falcon/regression/testHelper/BaseTestClass.java
>  a282ee0 
>   
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/AuthorizationTest.java
>  ad697fc 
>   
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ELExpFutureAndLatestTest.java
>  aea788a 
>   
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ELValidationsTest.java
>  1306dc3 
>   
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/EmbeddedPigScriptTest.java
>  c0113cd 
>   
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ExternalFSTest.java
>  bb63985 
>   
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedClusterUpdateTest.java
>  a24a0ee 
>   
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedInstanceStatusTest.java
>  5929117 
>   
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedLateRerunTest.java
>  569f380 
>   
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedReplicationTest.java
>  35842e4 
>   
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedResumeTest.java
>  49e4b62 
>   
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedScheduleTest.java
>  c498807 
>   
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedStatusTest.java
>  57a6164 
>   
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedSubmitAndScheduleTest.java
>  14f0517 
>   
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedSubmitTest.java
>  bcee706 
>   
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedSuspendTest.java
>  6b74b37 
>   
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/InstanceParamTest.java
>  a83a319 
>   
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/InstanceSummaryTest.java
>  23f93ac 
>   
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/NewRetryTest.java
>  b5aa514 
>   
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/NoOutputProcessTest.java
>  9f23f06 
>   
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessFrequencyTest.java
>  3ce68c4 
>   
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceColoMixedTest.java
>  21dc8de 
>   
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceKillsTest.java
>  a45911f 
>   
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceRerunTest.java
>  bab17c2 
>   
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceResumeTest.java
>  f42ef1c 
>   
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceRunningTest.java
>  d161a82 
>   
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceStatusTest.java
>  adbfd2c 
>   
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceSuspendTest.java
>  6058713 
>   
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessLateRerunTest.java
>  20129cb 
>   
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessLibPathTest.java
>  2dd9241 
>   
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/entity/ListEntitiesTest.java
>  9bfbe25 
>   
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/hcat/HCatFeedOperationsTest.java
>  04bcdce 
>   
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/hcat/HCatProcessTest.java
>  2c33337 
>   
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/hcat/HCatReplicationTest.java
>  bf01a4a 
>   
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/hcat/HCatRetentionTest.java
>  bfae1c6 
>   
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/EntitySummaryTest.java
>  591810d 
>   
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/LineageApiProcessInstanceTest.java
>  f29cbfe 
>   
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/LineageApiTest.java
>  0daa0f0 
>   
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/ListFeedInstancesTest.java
>  b90c8ed 
>   
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/ListProcessInstancesTest.java
>  49efcb8 
>   
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/ProcessPipelineTest.java
>  b20f0b6 
>   
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/EntityDryRunTest.java
>  92adf23 
>   
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/FeedDelayParallelTimeoutTest.java
>  847b23d 
>   
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/NewPrismProcessUpdateTest.java
>  4bd91e4 
>   
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/OptionalInputTest.java
>  1295909 
>   
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismClusterDeleteTest.java
>  47e0087 
>   
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismConcurrentRequestTest.java
>  69d38ad 
>   
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedDeleteTest.java
>  d65d98e 
>   
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedLateReplicationTest.java
>  dd5579f 
>   
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedReplicationPartitionExpTest.java
>  eca9efc 
>   
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedReplicationUpdateTest.java
>  6298619 
>   
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedResumeTest.java
>  42cf4f3 
>   
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedScheduleTest.java
>  0154591 
>   
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedSnSTest.java
>  d4bcfeb 
>   
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedSuspendTest.java
>  ae0cff3 
>   
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedUpdateTest.java
>  49795bc 
>   
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismProcessDeleteTest.java
>  f11f2e0 
>   
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismProcessResumeTest.java
>  d3f37ac 
>   
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismProcessScheduleTest.java
>  c3dcf6e 
>   
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismProcessSnSTest.java
>  b802d0a 
>   
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismProcessSuspendTest.java
>  7c927b0 
>   
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismSubmitTest.java
>  9cd3a34 
>   
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/ProcessPartitionExpVariableTest.java
>  9585b41 
>   
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/RescheduleKilledProcessTest.java
>  1ad24c2 
>   
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/RescheduleProcessInFinalStatesTest.java
>  4856aba 
>   
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/RetentionTest.java
>  ac4aac8 
>   
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/UpdateAtSpecificTimeTest.java
>  6a78bbb 
>   
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/AclValidationTest.java
>  71259cc 
>   
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/ClusterAclTest.java
>  7c56788 
>   
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/EntityOp.java
>  ad069de 
>   
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/FalconClientTest.java
>  6ea2be3 
>   
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/FeedAclTest.java
>  3d052a4 
>   
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/ProcessAclTest.java
>  12270d0 
>   
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ui/LineageGraphTest.java
>  22568f8 
>   
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ui/ProcessUITest.java
>  42bfe49 
> 
> Diff: https://reviews.apache.org/r/30450/diff/
> 
> 
> Testing
> -------
> 
> ListEntitiesTest, OptionalInputTest, RetentionTest, ProcessPipelineTest, 
> LineageApiTest,..
> 
> 
> Thanks,
> 
> Ruslan Ostafiychuk
> 
>

Reply via email to