----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30721/#review73527 -----------------------------------------------------------
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/HadoopUtil.java <https://reviews.apache.org/r/30721/#comment119922> in remote case it might be possible that file name may contain "_SUCCESS" . Its better to check for exact name, since we are sure it should be _SUCCESS. falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/HadoopUtil.java <https://reviews.apache.org/r/30721/#comment119923> we can directly have return statement here "return true" - samarth gupta On Feb. 6, 2015, 9:27 a.m., PRAGYA MITTAL wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30721/ > ----------------------------------------------------------- > > (Updated Feb. 6, 2015, 9:27 a.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1017 and FALCON-556 > https://issues.apache.org/jira/browse/FALCON-1017 > https://issues.apache.org/jira/browse/FALCON-556 > > > Repository: falcon-git > > > Description > ------- > > Modifying FeedReplicationTest to check for _SUCCESS availability on target > directory as per FALCON-556 > > > Diffs > ----- > > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/HadoopUtil.java > 64574a5 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedReplicationTest.java > b88cffc > > Diff: https://reviews.apache.org/r/30721/diff/ > > > Testing > ------- > > Done. > > > Thanks, > > PRAGYA MITTAL > >
