----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31622/#review75155 -----------------------------------------------------------
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessLibPathLoadTest.java <https://reviews.apache.org/r/31622/#comment122119> can we move this to before class ? i dont think it makes sense to download it before every test. Also since only one test is using the downloaded jar currently we can even have this as part of that test. - samarth gupta On March 4, 2015, 6:52 a.m., PRAGYA MITTAL wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31622/ > ----------------------------------------------------------- > > (Updated March 4, 2015, 6:52 a.m.) > > > Review request for Falcon and samarth gupta. > > > Bugs: FALCON-964 > https://issues.apache.org/jira/browse/FALCON-964 > > > Repository: falcon-git > > > Description > ------- > > This test points to a jar at remote public location that can be downloaded > when test are run.It tests important feature of user provided libs / jars > being loaded and used by tasktracker / nodemanager while launching the actual > task. > > > Diffs > ----- > > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/enumsAndConstants/MerlinConstants.java > 1c517b4 > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/OSUtil.java > dd5e194 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessLibPathLoadTest.java > PRE-CREATION > falcon-regression/merlin/src/test/resources/oozieLib/workflow.xml > PRE-CREATION > > Diff: https://reviews.apache.org/r/31622/diff/ > > > Testing > ------- > > Done. > > > Thanks, > > PRAGYA MITTAL > >
