----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31764/#review75313 -----------------------------------------------------------
Ship it! Ship It! - Srikanth Sundarrajan On March 5, 2015, 8:40 a.m., Pallavi Rao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31764/ > ----------------------------------------------------------- > > (Updated March 5, 2015, 8:40 a.m.) > > > Review request for Falcon and Srikanth Sundarrajan. > > > Bugs: FALCON-1063 > https://issues.apache.org/jira/browse/FALCON-1063 > > > Repository: falcon-git > > > Description > ------- > > Two places where ACLs of entities were expected: > 1. While listing/submiting/updating entities. > 2. LogCleanupService to delete logs as the entity owner. > > Added code to fallback on system user if ACL is not specified for an entity. > > > Diffs > ----- > > common/src/main/java/org/apache/falcon/cleanup/AbstractCleanupHandler.java > 5a4dce6 > common/src/main/java/org/apache/falcon/security/SecurityUtil.java b9fd37e > common/src/test/java/org/apache/falcon/cleanup/LogCleanupServiceTest.java > 8e2e544 > common/src/test/java/org/apache/falcon/security/SecurityUtilTest.java > a36d916 > prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java > 9a044d9 > > prism/src/main/java/org/apache/falcon/security/FalconAuthorizationFilter.java > 6b022c9 > > Diff: https://reviews.apache.org/r/31764/diff/ > > > Testing > ------- > > UTs added. UTs and ITs run. Upgrade/compatibility testing will be done by QA > team. > > > Thanks, > > Pallavi Rao > >
