----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31726/#review75375 -----------------------------------------------------------
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/OozieUtil.java <https://reviews.apache.org/r/31726/#comment122394> Wouldn't this return missing dependency of only the last instance ? Also, consider implementinng getMissingDependenciesForBundle() method. createMissingDependenciesForBundle() can use this new method. falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedInstanceListingTest.java <https://reviews.apache.org/r/31726/#comment122381> The test is applicable even in embedded mode - please tag as embedded. @Test(groups = "embedded") falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedInstanceListingTest.java <https://reviews.apache.org/r/31726/#comment122395> For javadoc please use /** ... */ Please fix this for other methods also. falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedInstanceListingTest.java <https://reviews.apache.org/r/31726/#comment122392> Do we want to assert that CLUSTER,INSTANCE, SIZE, CREATION-TIME, URI etc. are null/non-null ? - Raghav Gautam On March 4, 2015, 10:57 p.m., Karishma Gulati wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31726/ > ----------------------------------------------------------- > > (Updated March 4, 2015, 10:57 p.m.) > > > Review request for Falcon. > > > Repository: falcon-git > > > Description > ------- > > Falcon processes or feed replication provides status on instances. When the > instance status is WAITING for input, users have difficulty in identifying > what feed is missing. In general it would very helpful to users to get feed > availability status natively through falcon. > > More description given at : https://issues.apache.org/jira/browse/FALCON-761 > > > Diffs > ----- > > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/entity/AbstractEntityHelper.java > 7d38261 > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/InstanceUtil.java > 5d4e657 > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/OozieUtil.java > 3cc171f > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/Util.java > ab09ff1 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedInstanceListingTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/31726/diff/ > > > Testing > ------- > > > Thanks, > > Karishma Gulati > >
