> On March 5, 2015, 8:43 p.m., Raghav Gautam wrote: > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/InstanceParamTest.java, > > line 112 > > <https://reviews.apache.org/r/31133/diff/1/?file=866515#file866515line112> > > > > Can we name variables like prismResponse, cluster1Response ? Using two > > variables should be fine. Also, applicable for other methods. > > > > I may be missing something here, but why cluster1Response will have > > only 5 instances and prismResponse will have 15 ?
Since the process xml contains multiple clusters, each cluster will schedule it's own 5 instances of that process. Hene, when we query the server, we'll get a response containing just the 5 instances of that server, and when we query the prism, we'll get all 15 instances, corresponding to all the clusters mentioned in the process xml. - Karishma ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31133/#review75387 ----------------------------------------------------------- On Feb. 17, 2015, 8:30 p.m., Karishma Gulati wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31133/ > ----------------------------------------------------------- > > (Updated Feb. 17, 2015, 8:30 p.m.) > > > Review request for Falcon. > > > Repository: falcon-git > > > Description > ------- > > InstanceParamsTest currently just hits the api and logs the response. Adding > validations to the test to validate the response > > > Diffs > ----- > > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/InstanceParamTest.java > c8b76e9 > > Diff: https://reviews.apache.org/r/31133/diff/ > > > Testing > ------- > > Made changes to InstanceParamsTest > > > Thanks, > > Karishma Gulati > >
