----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32097/#review76717 -----------------------------------------------------------
common/src/main/java/org/apache/falcon/catalog/HiveCatalogService.java <https://reviews.apache.org/r/32097/#comment124344> The table instance will not be null, coz., an exception is thrown if the table does not exist or if any other Hive client error occurs. So, NPE should not occur here. - Pallavi Rao On March 16, 2015, 10:43 a.m., Pallavi Rao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32097/ > ----------------------------------------------------------- > > (Updated March 16, 2015, 10:43 a.m.) > > > Review request for Falcon and Suhas Vasu. > > > Repository: falcon-git > > > Description > ------- > > This patch is based on code submitted by Shwetha G S via FALCON-703. > Following changes have been made: > 1. Breaking UTs/ITs fixed. > 2. Checkstyle errors fixed. > 3. Disabled the new IT as it clashes (config) with existing ones. > > > Diffs > ----- > > common/src/main/java/org/apache/falcon/catalog/AbstractCatalogService.java > 9abdc93 > common/src/main/java/org/apache/falcon/catalog/CatalogPartitionHandler.java > PRE-CREATION > common/src/main/java/org/apache/falcon/catalog/HiveCatalogService.java > 25a4a46 > common/src/main/java/org/apache/falcon/entity/CatalogStorage.java 59f558b > common/src/main/java/org/apache/falcon/entity/FeedHelper.java ca31f95 > common/src/main/java/org/apache/falcon/entity/FileSystemStorage.java > 1ba7b9d > common/src/main/java/org/apache/falcon/entity/common/FeedDataPath.java > 6ededbb > common/src/main/java/org/apache/falcon/expression/ExpressionHelper.java > 33ec59c > common/src/main/java/org/apache/falcon/util/FalconRadixUtils.java 4bf6e00 > > common/src/main/java/org/apache/falcon/workflow/WorkflowExecutionContext.java > 8d69b9a > common/src/main/resources/startup.properties 99dab59 > common/src/test/java/org/apache/falcon/entity/FeedDataPathTest.java c405556 > common/src/test/java/org/apache/falcon/entity/FeedHelperTest.java f6994fc > common/src/test/java/org/apache/falcon/entity/FileSystemStorageTest.java > 1667161 > > hadoop-dependencies/src/versioned-src/v2/java/org/apache/hadoop/mapred/ClassicClientProtocolProvider.java > 2167375 > oozie/src/main/java/org/apache/falcon/logging/LogProvider.java 2e5dffb > > oozie/src/main/java/org/apache/falcon/oozie/process/ProcessExecutionCoordinatorBuilder.java > 7a87919 > > oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java > 62c04ea > > oozie/src/test/java/org/apache/falcon/oozie/process/OozieProcessWorkflowBuilderTest.java > ef21f4d > prism/pom.xml 4a3054a > prism/src/main/java/org/apache/falcon/Main.java de9f657 > prism/src/main/java/org/apache/falcon/listener/ContextStartupListener.java > 5e879b1 > prism/src/main/java/org/apache/falcon/util/EmbeddedServer.java 788df58 > prism/src/main/java/org/apache/falcon/util/SecureEmbeddedServer.java > 8e9ef52 > retention/src/test/java/org/apache/falcon/retention/FeedEvictorTest.java > 970d381 > > test-tools/hadoop-webapp/src/main/java/org/apache/falcon/listener/HadoopStartupListener.java > 7bee592 > test-tools/hadoop-webapp/src/main/resources/mapred-site.xml cf297de > test-tools/hadoop-webapp/src/main/resources/yarn-site.xml 658752b > > webapp/src/test/java/org/apache/falcon/catalog/CatalogPartitionHandlerIT.java > PRE-CREATION > webapp/src/test/java/org/apache/falcon/catalog/HiveCatalogServiceIT.java > 71616e9 > > webapp/src/test/java/org/apache/falcon/lifecycle/TableStorageFeedEvictorIT.java > 6982b65 > webapp/src/test/java/org/apache/falcon/util/HiveTestUtils.java 19274b9 > webapp/src/test/java/org/apache/falcon/util/OozieTestUtils.java e67fe2a > webapp/src/test/resources/cluster-template.xml 16b7c8c > webapp/src/test/resources/feed-template1.xml 456f7ce > webapp/src/test/resources/feed-template2.xml d4901fa > > Diff: https://reviews.apache.org/r/32097/diff/ > > > Testing > ------- > > One end-to-end manual test done for partition creation. > > > Thanks, > > Pallavi Rao > >
