> On April 8, 2015, 10:51 p.m., Raghav Gautam wrote: > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/Entities/FeedMerlin.java, > > line 337 > > <https://reviews.apache.org/r/32814/diff/1/?file=914690#file914690line337> > > > > Is it ok to assume that the path that you want to set will always be > > the first element in the list ?
Method was moved from InstanceUtil. I add some info to javadoc and will open a jira for methods like this. - Ruslan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32814/#review79440 ----------------------------------------------------------- On April 9, 2015, 10:47 a.m., Ruslan Ostafiychuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32814/ > ----------------------------------------------------------- > > (Updated April 9, 2015, 10:47 a.m.) > > > Review request for Falcon. > > > Bugs: Falcon-1135 > https://issues.apache.org/jira/browse/Falcon-1135 > > > Repository: falcon-git > > > Description > ------- > > Migrate methods related to *Merlin.java classes from InstanceUtil.java and > Bundle.java > > > Diffs > ----- > > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/Entities/ClusterMerlin.java > 22ec5da > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/Entities/FeedMerlin.java > 70e2e73 > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/Entities/ProcessMerlin.java > 01fdd04 > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/bundle/Bundle.java > b0fa0a5 > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/BundleUtil.java > 0b2c4e1 > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/InstanceUtil.java > 4620787 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/AuthorizationTest.java > eaa69f0 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ELExpCurrentAndLastWeekTest.java > b7eb77f > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ELValidationsTest.java > 41e3002 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ExternalFSTest.java > 6b227d6 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedInstanceListingTest.java > a6639ed > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedLateRerunTest.java > 2c8346d > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedReplicationTest.java > eb8c4fe > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/LogMoverTest.java > 4ce6026 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/NewRetryTest.java > 13a9776 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/NoOutputProcessTest.java > 59a701d > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessFrequencyTest.java > 8cf2862 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceColoMixedTest.java > 48cb59b > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceKillsTest.java > 34dfce3 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceResumeTest.java > f558cc5 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceRunningTest.java > c9334eb > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceStatusTest.java > 58936a7 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceSuspendTest.java > 26348bd > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessLateRerunTest.java > b41cf05 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessSLATest.java > cd7eba4 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ValidateAPIPrismAndServerTest.java > 9886d76 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/entity/EntitiesPatternSearchTest.java > f9fcf8d > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/entity/ListEntitiesTest.java > 13b3b88 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/hcat/HCatProcessTest.java > 202298e > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/NewPrismProcessUpdateTest.java > 4466c13 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/OptionalInputTest.java > c9e373e > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedReplicationPartitionExpTest.java > 97d4e67 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedReplicationUpdateTest.java > e1a96f3 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedUpdateTest.java > 483c281 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismProcessDeleteTest.java > f1ff8fe > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismProcessScheduleTest.java > 03f380d > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismProcessSnSTest.java > dfb405f > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismSubmitTest.java > 7bc4b5b > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/ProcessPartitionExpVariableTest.java > 272ac3b > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/RescheduleKilledProcessTest.java > 1d65d12 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/RescheduleProcessInFinalStatesTest.java > 7e4422b > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/UpdateAtSpecificTimeTest.java > 0cc0d6e > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ui/ProcessUITest.java > 4c54409 > > Diff: https://reviews.apache.org/r/32814/diff/ > > > Testing > ------- > > tested > > > Thanks, > > Ruslan Ostafiychuk > >
