[
https://issues.apache.org/jira/browse/FALCON-1161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14505090#comment-14505090
]
Peeyush Bishnoi commented on FALCON-1161:
-----------------------------------------
[~suhas.ysr] Patch looks good. But in the given patch can you just remove the
following Assert statement from test case feedFeedBasePathExists.
{code}
// There should not be any sub directories under the base path
Assert.assertEquals(fs.listStatus(new Path(feedBasePathString)).length, 0);
{code}
As chances are there that when month get change this test case may get fail as
list of directories will not be 0. For this test case only requirement is that
feed base path must exists as I have mentioned in other comments.
> Test case feedFeedBasePathExists fails intermittently
> -----------------------------------------------------
>
> Key: FALCON-1161
> URL: https://issues.apache.org/jira/browse/FALCON-1161
> Project: Falcon
> Issue Type: Bug
> Components: retention
> Affects Versions: 0.6.1
> Reporter: Peeyush Bishnoi
> Assignee: Suhas Vasu
> Fix For: 0.6.1
>
> Attachments: FALCON-1161.patch, FALCON-1161.patch,
> FALCON-1161.v1.patch
>
>
> Test case testFeedBasePathExists in FeedEvictorTest class fails
> intermittently when number of directories deleted do not match with expected
> output in following Assert statement.
> {code}
> Assert.assertEquals((beforeDelCount - afterDelCount), 11);
> {code}
> testFeedBasePathExists(org.apache.falcon.retention.FeedEvictorTest) Time
> elapsed: 0.299 sec <<< FAILURE!
> java.lang.AssertionError: expected:<11> but was:<12>
> at org.testng.Assert.fail(Assert.java:89)
> at org.testng.Assert.failNotEquals(Assert.java:489)
> at org.testng.Assert.assertEquals(Assert.java:118)
> at org.testng.Assert.assertEquals(Assert.java:260)
> at org.testng.Assert.assertEquals(Assert.java:270)
> at
> org.apache.falcon.retention.FeedEvictorTest.testFeedBasePathExists(FeedEvictorTest.java:452)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
