----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31793/#review81080 -----------------------------------------------------------
common/src/main/java/org/apache/falcon/security/AuthenticationInitializationService.java <https://reviews.apache.org/r/31793/#comment131310> With Falcon-1144 dependency was updated to common-langs3. Can you use org.apache.commons.lang3.StringUtils instead? common/src/main/java/org/apache/falcon/security/AuthenticationInitializationService.java <https://reviews.apache.org/r/31793/#comment131314> Is this used anywhere else? If not make it private. Also this property is not in startup.properties currently, can you add it so that user knows it can be overridden. common/src/main/java/org/apache/falcon/security/AuthenticationInitializationService.java <https://reviews.apache.org/r/31793/#comment131312> Can we add the granularity of time to constant? Is it in ms? common/src/main/java/org/apache/falcon/security/AuthenticationInitializationService.java <https://reviews.apache.org/r/31793/#comment131318> Do we want to catch NumberFormatException and return more helpful error message? common/src/main/java/org/apache/falcon/security/AuthenticationInitializationService.java <https://reviews.apache.org/r/31793/#comment131316> alertLogCleanupServiceFailed seems inappropriate, can you add a new alert method? - Sowmya Ramesh On March 6, 2015, 7:41 a.m., Balu Vellanki wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31793/ > ----------------------------------------------------------- > > (Updated March 6, 2015, 7:41 a.m.) > > > Review request for Falcon. > > > Bugs: https://issues.apache.org/jira/browse/FALCON-954 > > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/FALCON-954 > > > Repository: falcon-git > > > Description > ------- > > Secure Kerberos setup : Falcon should periodically revalidate auth token. > > > Diffs > ----- > > > common/src/main/java/org/apache/falcon/security/AuthenticationInitializationService.java > fbed283 > > Diff: https://reviews.apache.org/r/31793/diff/ > > > Testing > ------- > > Ran unit and system tests. Successfully started Falcon in secure mode. > > > Thanks, > > Balu Vellanki > >
