----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33396/#review81092 -----------------------------------------------------------
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/SearchApiTest.java <https://reviews.apache.org/r/33396/#comment131336> Lot of methods in the test seem to have multiple parameters. Some of these are arrays. If we start using two private classes one for query params and another one for search results, the code will become more readable. Eg: QueryParam.forEntityType("schedulable").withNameSeq(base + "-bundle1-feed").withField("tags").withNumResults(3).withOrderBy("desc"); SearchResult can additionally have assertEqual(EntityList entityList) to do the assertions. - Raghav Gautam On April 21, 2015, 8:15 a.m., Paul Isaychuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33396/ > ----------------------------------------------------------- > > (Updated April 21, 2015, 8:15 a.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1171 > https://issues.apache.org/jira/browse/FALCON-1171 > > > Repository: falcon-git > > > Description > ------- > > Adding tests for search API > > > Diffs > ----- > > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/entity/AbstractEntityHelper.java > b899f1a > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/SearchApiTest.java > PRE-CREATION > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/entity/ListEntitiesTest.java > 3ae44e6 > > Diff: https://reviews.apache.org/r/33396/diff/ > > > Testing > ------- > > All tests pass > > > Thanks, > > Paul Isaychuk > >
