> On April 28, 2015, 7:30 p.m., Sowmya Ramesh wrote: > > common/src/test/java/org/apache/falcon/entity/parser/ClusterEntityParserTest.java, > > line 344 > > <https://reviews.apache.org/r/33632/diff/2/?file=944298#file944298line344> > > > > If clusterEntityParser.validate throws ValidationException, control > > won't even enter this code isn't? > > Venkatesan Ramachandran wrote: > The removeDir seems to be superflous after testing with the latest code.
Can we remove this then? - Sowmya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33632/#review81866 ----------------------------------------------------------- On April 28, 2015, 8:58 p.m., Venkatesan Ramachandran wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33632/ > ----------------------------------------------------------- > > (Updated April 28, 2015, 8:58 p.m.) > > > Review request for Falcon, Sowmya Ramesh and Suhas Vasu. > > > Repository: falcon-git > > > Description > ------- > > FALCON-1162 : Cluster submit succeeds when staging HDFS dir does not have 777 > (ALL) permission > > > Diffs > ----- > > > common/src/main/java/org/apache/falcon/entity/parser/ClusterEntityParser.java > 4eb3ea8 > > common/src/test/java/org/apache/falcon/entity/parser/ClusterEntityParserTest.java > acc14a4 > docs/src/site/twiki/EntitySpecification.twiki 758d591 > > Diff: https://reviews.apache.org/r/33632/diff/ > > > Testing > ------- > > + create cluster definition with a staging dir, say dir-1 > + make dir-1 on HDFS and set its permission to 755 > + submit clutser > + create a process and submit process > > The process fails at launch time when the staging permission is 755 > > This patch will catch this issue at the time of creating cluster. > > > Thanks, > > Venkatesan Ramachandran > >
