----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33899/#review82768 -----------------------------------------------------------
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/enumsAndConstants/MerlinConstants.java <https://reviews.apache.org/r/33899/#comment133578> Using merlin prefix is inconsistent with our coding convention. Other similar properties have names like: current_user_keytab user2_name = hrt_1 user2_keytab = none - Raghav Gautam On May 6, 2015, 10:01 a.m., Ruslan Ostafiychuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33899/ > ----------------------------------------------------------- > > (Updated May 6, 2015, 10:01 a.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1198 > https://issues.apache.org/jira/browse/FALCON-1198 > > > Repository: falcon-git > > > Description > ------- > > Test witch buttons should be available in different situations. > Check changed on UI statuses via API. > merlin.current_user_name property can be used to change user.name for API > operations. > > > Diffs > ----- > > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/enumsAndConstants/MerlinConstants.java > 7f0f5c7 > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/request/BaseRequest.java > a70ceeb > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/request/RequestKeys.java > 3232978 > > falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/SearchPage.java > 9ad2591 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/EntitiesTableReflectionTest.java > 8d64a0e > > Diff: https://reviews.apache.org/r/33899/diff/ > > > Testing > ------- > > Tested > > > Thanks, > > Ruslan Ostafiychuk > >
