> On May 7, 2015, 4:48 a.m., Pallavi Rao wrote: > > oozie/src/main/java/org/apache/falcon/service/SharedLibraryHostingService.java, > > line 49 > > <https://reviews.apache.org/r/33892/diff/1/?file=951149#file951149line49> > > > > Using an instance variable to differentiate between add and reload will > > make it thread-unsafe. > > Add and reload may not happen simultaneously in this case, but, lets > > keep it thread safe, anyway. You can achieve the same using method > > variables. > > > > You can add another private method: > > private addEntity(Entity entity, isReload){..} > > > > public onAdd(Entity entity) { > > addEntity(entity, false); > > } > > > > public onReload(Entity entity) { > > addEntity(entity, true); > > }
Used method variables as suggested. > On May 7, 2015, 4:48 a.m., Pallavi Rao wrote: > > oozie/src/main/java/org/apache/falcon/service/SharedLibraryHostingService.java, > > line 82 > > <https://reviews.apache.org/r/33892/diff/1/?file=951149#file951149line82> > > > > Don't think you need fsException variable at all. Using, > > if (!reloadEntity) { > > throw FalconException(...); > > } > > should do it. Isn't it? I need to set variable fsException = true, if FS exception occurred while reloading cluster entity on Falcon server restart. If I don't set this, then Falcon server will try to add/update jar file for unavailable FS. - Peeyush ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33892/#review82790 ----------------------------------------------------------- On May 6, 2015, 12:47 p.m., Peeyush Bishnoi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33892/ > ----------------------------------------------------------- > > (Updated May 6, 2015, 12:47 p.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1165 > https://issues.apache.org/jira/browse/FALCON-1165 > > > Repository: falcon-git > > > Description > ------- > > FALCON-1165 : Falcon restart failed, if defined service in cluster entity is > unreachable > > > Diffs > ----- > > > oozie/src/main/java/org/apache/falcon/service/SharedLibraryHostingService.java > b3b7bf3 > > Diff: https://reviews.apache.org/r/33892/diff/ > > > Testing > ------- > > Yes > > > Thanks, > > Peeyush Bishnoi > >
