----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33965/#review83401 -----------------------------------------------------------
falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/FeedWizardPage.java <https://reviews.apache.org/r/33965/#comment134389> lets use camel-case instead of "_". Also (int i=0; i < tags.length ;i++) -> (int i = 0; i < tags.length; i++) falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/FeedSetupTest.java <https://reviews.apache.org/r/33965/#comment134387> It seems that logger class should be FeedSetupTest - Paul Isaychuk On May 8, 2015, 12:58 a.m., Namit Maheshwari wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33965/ > ----------------------------------------------------------- > > (Updated May 8, 2015, 12:58 a.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1201 > https://issues.apache.org/jira/browse/FALCON-1201 > > > Repository: falcon-git > > > Description > ------- > > Test 1. testHeader > Test 2. testWizardDefaultScenario - Run full feed creation scenario. > > > Diffs > ----- > > > falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/AbstractSearchPage.java > eaaeba25307bf2f494d76cd5de080aadcbd6ce54 > > falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/FeedWizardPage.java > PRE-CREATION > > falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/NewFeedPage.java > 4863da3e146d23eef0f749766e5040d0a1cbc154 > > falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/PageHeader.java > b9d766f722377cf36eb08a938f8f38b143021f28 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/FeedSetupTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/33965/diff/ > > > Testing > ------- > > Tested, that the pages are filled fine and test pass. > > > Thanks, > > Namit Maheshwari > >
