----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34192/#review83901 -----------------------------------------------------------
common/src/main/java/org/apache/falcon/metadata/MetadataMappingService.java <https://reviews.apache.org/r/34192/#comment134979> Agree with Balu here, all the methods, onAdd, onChange and onSuccess can be modified to make it less repetitive. Either create new methods in EntityGraphBuilder. Or, put the switch-case inside the method of the anonymous class. That way, the creation of anonymous class doesn't get repeated. - Pallavi Rao On May 14, 2015, 5:52 a.m., pavan kumar kolamuri wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34192/ > ----------------------------------------------------------- > > (Updated May 14, 2015, 5:52 a.m.) > > > Review request for Falcon. > > > Repository: falcon-git > > > Description > ------- > > Handle transaction failures in Lineage , Rolling back transactions if they > are partial. > > > Diffs > ----- > > > common/src/main/java/org/apache/falcon/metadata/EntityRelationshipGraphBuilder.java > d90f7ec > > common/src/main/java/org/apache/falcon/metadata/InstanceRelationshipGraphBuilder.java > 2288443 > common/src/main/java/org/apache/falcon/metadata/MetadataMappingService.java > 9137fe0 > > common/src/test/java/org/apache/falcon/metadata/MetadataMappingServiceTest.java > 11d27fe > pom.xml 47718ba > > Diff: https://reviews.apache.org/r/34192/diff/ > > > Testing > ------- > > > Thanks, > > pavan kumar kolamuri > >
