Regarding canceling a patch, +1 for it. But, I think we need to layout the guidelines a little more clearly as to who cancels the patch and when should it be cancelled.
If a patch is cancelled by a reviewer/committer, the rest of the community may miss reviewing the patch. And, when the patch is updated, the community may provide further or conflicting comments. So, I suggest that the owner of the JIRA cancel the patch. When should one cancel the patch? A few days after the first reviewer has provided his comments, giving some time for others to review it. The time interval again can be left to the discretion of the owner, based on the size and nature of the patch. Basically, he/she will cancel the patch when re-work on the patch begins. As always, comments welcome. On Fri, May 15, 2015 at 12:49 PM, pavan kumar Kolamuri < [email protected]> wrote: > +1 for this approach . It will be good for new one's to start contribute as > well . > > On Thu, May 14, 2015 at 4:05 PM, Srikanth Sundarrajan <[email protected] > > > wrote: > > > I know few other projects at ASF follow the practice of cancelling > patches > > when more work is required on it to keep the "Patch Available" queue > small > > and with something that requires immediate attention. Am +1 on this. > > > > +1 for tagging jira's with "newbie" as well. One needs to update the > cwiki > > article in How To contribute accordingly as well. > > > > Regards > > Srikanth Sundarrajan > > > > > From: [email protected] > > > Date: Thu, 14 May 2015 11:24:44 +0530 > > > Subject: [DISCUSS] - Cancel Patches & newbie JIRAs > > > To: [email protected] > > > > > > Hi Everyone, > > > > > > Currently we have around 30 issues in Patch Available state. To keep > this > > > queue short and to distinguish the issues which haven't been reviewed > > from > > > the issues which have been reviewed but need further work, I propose > that > > > we should change the state to Open (by cancelling the patch). This way > we > > > can review patches which need to be looked at more efficiently and > > > frequently. > > > > > > My second suggestion is to start creating some "nice to have" JIRAs > which > > > are suitable for new comers and label them as *newbie. *This will help > > new > > > comers who want to contribute to the project. Experienced contributors > > > should avoid assigning these JIRAs to themselves unless absolutely > > > necessary. Help from other committers towards creating more newbie > JIRAs > > is > > > very welcome. > > > > > > Thoughts? > > > > > > Cheers > > > Ajay Yadava > > > > > > > > -- > Regards > Pavan Kumar Kolamuri > -- _____________________________________________________________ The information contained in this communication is intended solely for the use of the individual or entity to whom it is addressed and others authorized to receive it. It may contain confidential or legally privileged information. If you are not the intended recipient you are hereby notified that any disclosure, copying, distribution or taking any action in reliance on the contents of this information is strictly prohibited and may be unlawful. If you have received this communication in error, please notify us immediately by responding to this email and then delete it from your system. The firm is neither liable for the proper and complete transmission of the information contained in this communication nor for any delay in its receipt.
