----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34240/#review84989 -----------------------------------------------------------
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/FeedSetupTest.java <https://reviews.apache.org/r/34240/#comment136453> Can we place all feed properties checks to respective FeedMerlin static methods like: static boolean asserEquals(Properties props1, Properties props2); static boolean asserEquals(ACL acl1, ACL acl2) etc, or something like this. Thus we can reduce the code. You might take a look into ClusterMerlin as example. - Paul Isaychuk On May 21, 2015, 11:24 p.m., Namit Maheshwari wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34240/ > ----------------------------------------------------------- > > (Updated May 21, 2015, 11:24 p.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1222 > https://issues.apache.org/jira/browse/FALCON-1222 > > > Repository: falcon-git > > > Description > ------- > > Feed Wizard multiple tests > > > Diffs > ----- > > > falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/AbstractSearchPage.java > e72ce6706d7fe3331744d723894193bfbaff586a > > falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/FeedWizardPage.java > 6eed4cef86c1974c3d30f0133b34894e24ac1750 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/FeedSetupTest.java > 8920f41129175a207ae6dee0659a514fef17bcfc > > Diff: https://reviews.apache.org/r/34240/diff/ > > > Testing > ------- > > Below new tests added. Tested the same. > testWizardCancel > testWizardXmlPreview > testGeneralStepEditXml > testGeneralStepDefaultScenario > testGeneralStepXmlPreview > testGeneralStepAddRemoveTag > testGeneralStepBlankOptionalFields > testTimingStepDefaultScenario > testTimingStepXmlPreview > testTimingStepEditXml > testTimingStepDropDownLists > testTimingStepAddDeleteProperties > testLocationStepValidValuesFS > testLocationStepValidCatalogStorage > testLocationStepBothLocationsAndTableUri > testLocationStepEditXml > testClustersStepDefaultScenario > testClustersStepDropDownLists > testClustersStepDefaultLocations > testClusterStepEditXml > testSummaryStepDefaultScenario > > > Thanks, > > Namit Maheshwari > >
