> On May 29, 2015, 8:42 p.m., Raghav Gautam wrote: > > falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/AbstractSearchPage.java, > > line 86 > > <https://reviews.apache.org/r/34793/diff/1/?file=973975#file973975line86> > > > > why has this been made public ? I think we were using this only within > > childs of AbstractSearchPage. Is that no longer the case ?
Made it public, such that it can be used by SearchUI tests as well. > On May 29, 2015, 8:42 p.m., Raghav Gautam wrote: > > falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/ClusterWizardPage.java, > > line 454 > > <https://reviews.apache.org/r/34793/diff/1/?file=973976#file973976line454> > > > > This method is used at only one place with true parameter. I think it > > can be inlined. Yes, this can be inlined. But with the thought of consistency with these type of functions, I made it like this. Feed and Process has few similar methods. Let me know if you want it to be changed. - Namit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34793/#review85802 ----------------------------------------------------------- On May 29, 2015, 12:29 a.m., Namit Maheshwari wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34793/ > ----------------------------------------------------------- > > (Updated May 29, 2015, 12:29 a.m.) > > > Review request for Falcon. > > > Repository: falcon-git > > > Description > ------- > > More Search UI tests > > > Diffs > ----- > > > falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/AbstractSearchPage.java > 780cd0ce53f3e9507f9892ea75c8bb8938fc6f43 > > falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/ClusterWizardPage.java > 300a3d63eca44e0c99a856e646dbb233def7e9fa > > falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/PageHeader.java > c84cfe550c7c75ea808c23798a617df44ebc3c6d > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/HomePageTest.java > b752a869c9ad70a4c24ff51a3350269b9e21be3e > > Diff: https://reviews.apache.org/r/34793/diff/ > > > Testing > ------- > > Below new tests added: > testUploadEntity > testUploadBadEntity > clusterSetupNameAvailability > > Have tested them on local > > > Thanks, > > Namit Maheshwari > >
