----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35596/ -----------------------------------------------------------
Review request for Falcon. Repository: falcon-git Description ------- 1) Falcon instance summary returns a consolidated instance summary of all instances between the specified time range. It would be helpful to add filtering capability on this result. For ex:- Give me all killed instances for a particular time range or Give me all succeeded instances for a time range This would be really helpful when someone wants to use falcon client methods / API's to do some monitoring on the process instances 2) Say I want to run falcon instance status command and i want to filter by RUNNING & KILLED instances. This would be done by issuing - -filterBy Status:SUCCEEDED,Status:KILLED In the server, we use a hashmap, because of which only one entry for Status will be retained and as a result the resultset will be filtered only by the last filter. We should use a data-structure that allows duplicate values for the same key. Diffs ----- client/src/main/java/org/apache/falcon/cli/FalconCLI.java f169917 client/src/main/java/org/apache/falcon/client/FalconClient.java 20c32e4 client/src/main/java/org/apache/falcon/resource/InstancesSummaryResult.java a3dcbe4 prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java a721666 prism/src/main/java/org/apache/falcon/resource/AbstractInstanceManager.java 72f9fe4 prism/src/main/java/org/apache/falcon/resource/AbstractSchedulableEntityManager.java 95e0e69 prism/src/main/java/org/apache/falcon/resource/proxy/InstanceManagerProxy.java 1a8396c webapp/src/main/java/org/apache/falcon/resource/InstanceManager.java c2ac5b2 Diff: https://reviews.apache.org/r/35596/diff/ Testing ------- All UT's have run successfully Also have manually run a pipeline and tested the features incorporated Thanks, Suhas Vasu
